shanyu commented on a change in pull request #25705: [SPARK-29003][CORE] Fix
deadlock in startup of Spark History Server
URL: https://github.com/apache/spark/pull/25705#discussion_r324386704
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala
##########
@@ -114,6 +114,11 @@ private[history] abstract class
ApplicationHistoryProvider {
*/
def stop(): Unit = { }
+ /**
+ * Called when the server is starting up.
Review comment:
@dongjoon-hyun This is the same as stop() that is called by the server
(HistoryServer), start() should be called during server starting up. I'll add a
few more sentence to describe that it should do and why we added it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
