rdblue commented on a change in pull request #25747: [SPARK-29039][SQL] 
centralize the catalog and table lookup logic
URL: https://github.com/apache/spark/pull/25747#discussion_r324401225
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ##########
 @@ -742,15 +751,49 @@ class Analyzer(
       case _ => plan
     }
 
+    private def tryResolveV2Relation(u: UnresolvedRelation): 
Option[DataSourceV2Relation] = {
 
 Review comment:
   I think this should continue to use extractors instead of inline logic. The 
rules are cleaner when written with extractors. We might need to update them, 
but I'd like to avoid methods like this one that do basically the same thing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to