zsxwing edited a comment on issue #25787: [SPARK-29081][CORE] Replace calls to SerializationUtils.clone on properties with a faster implementation URL: https://github.com/apache/spark/pull/25787#issuecomment-531453826 > The only functionality that would be changed is the unsupported insertion of non-String objects into the spark local properties. ~~I remember this was the reason we decided to use `SerializationUtils.clone` at the beginning. See https://github.com/apache/spark/pull/8710#discussion_r39238759~~ NVM. I just realized we don't have any public to set non-string values. Totally don't remember why we didn't use this simpler way. LGTM
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
