srowen commented on a change in pull request #25789: [SPARK-28927][ML] Show
warning when input data to ALS is indeterminate
URL: https://github.com/apache/spark/pull/25789#discussion_r324466158
##########
File path: R/pkg/R/mllib_recommendation.R
##########
@@ -82,6 +82,10 @@ setClass("ALSModel", representation(jobj = "jobj"))
#' statsS <- summary(modelS)
#' }
#' @note spark.als since 2.1.0
+#' @note the input rating dataframe to the ALS implementation should not be
indeterminate.
Review comment:
I still think we need to say "nondeterministic" and give an example
(randomSplit), but also tell people how to fix it. Define a partitioning? sort
order?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
