dongjoon-hyun commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-531597158 Yep. I agree that closing is one of the option, @HyukjinKwon and @srowen . And, another option in my mind is applying this rule in `master` and `branch-2.4` together. It will reduce the change of conflicts, @rxin . As of today, we only have a historically minimum number of live branch `master` and `branch-2.4`. This is a good timing to do this. Also, the logical sync is not hard to do because it's a maven rule. Anyway, shall we make a decision since this is open too long due to non-technical reason? We don't merge if we have one -1. cc @rxin , @gatorsmile , @cloud-fan , @maropu , @srowen , @HyukjinKwon , @wangyum .
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
