dongjoon-hyun commented on a change in pull request #25795: [SPARK-29037][Core]
Spark gives duplicate result when an application was killed
URL: https://github.com/apache/spark/pull/25795#discussion_r324480846
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
##########
@@ -1224,6 +1226,34 @@ class HiveQuerySuite extends HiveComparisonTest with
SQLTestUtils with BeforeAnd
}
}
}
+
+ test("SPARK-29037: Spark gives duplicate result when an application was
killed") {
Review comment:
Thanks for adding this. This looks like a good IT. If possible,
- Can we have a concise UT at `core` module because you are touching
`HadoopMapReduceCommitProtocol`?
- Otherwise, can we move this to `sql/core` module instead of `sql/hive`
because you are using `using parquet`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
