joshrosen-stripe commented on issue #25745: [SPARK-29033][SQL][WIP] Always use UnsafeRow-based version of CreateNamedStruct URL: https://github.com/apache/spark/pull/25745#issuecomment-531599373 While we're at it, there could be significant wins from eliminating the `if (project_tmpInput_0 instanceof UnsafeRow)` checks: if we can always use the `UnsafeRow` branch here then we can significantly reduce the generated code size (since most of the code is in the `else` branch). This could significantly reduce code size for wide Encoder projections, addressing a performance issue that I've seen in the wild (generating code which is too large to JIT).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
