HeartSaVioR commented on a change in pull request #25797: [SPARK-29043][Core]
Improve the concurrent performance of History Server
URL: https://github.com/apache/spark/pull/25797#discussion_r324490965
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -677,10 +682,35 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
/**
* Replay the given log file, saving the application in the listing db.
*/
+
protected def mergeApplicationListing(
fileStatus: FileStatus,
scanTime: Long,
enableOptimizations: Boolean): Unit = {
+ try {
+ mergeApplicationListingHelper(fileStatus, scanTime, enableOptimizations)
+ } catch {
+ case e: InterruptedException =>
Review comment:
You may want to recheck all expressions in catch statement are thread-safe,
for sure. (I don't know whether it's thread safe or not, but the logic is now
executed from multiple threads concurrently while it was executed from single
thread.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
