sujith71955 edited a comment on issue #25720: [SPARK-28930][SQL] Last Access 
Time value shall display 'UNKNOWN' in all clients
URL: https://github.com/apache/spark/pull/25720#issuecomment-531625336
 
 
   > I still don't quite understand it, are you trying to fix a cosmetic issue 
or a bug? I don't see a test that now passes with this change but didn't 
before. But I am also not clear that "UNKNOWN" or "NULL" is the desired output, 
either.
   
   After fixing JIRA SPARK-24812 the expectation is 'Last Access' shall be 
displayed as 'UNKNOWN' which is not happening right now as the value is shown 
as [Last Access,Thu Jan 01 08:00:00 CST 1970].
   
   As  analyzed i found the current logic  if (-1 == lastAccessTime) "UNKNOWN" 
else new Date(lastAccessTime).toString  is failing as the Last Access value 
comes as '0',
   its happens because of below logic which is executed in 
HiveClientImpl.toHiveTable() method.
   
![image](https://user-images.githubusercontent.com/12999161/64931760-3e922e80-d858-11e9-9875-1da9bafc4823.png).
 So i corrected it.
   
   Its basically a cosmetic bug. Even in hive (verified in 1.2) the last access 
will be shown as 'UNKNOWN' because currently no mechanism for evaluating last 
access. 
   Hope the background is clear now. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to