cloud-fan edited a comment on issue #25747: [SPARK-29039][SQL] centralize the 
catalog and table lookup logic
URL: https://github.com/apache/spark/pull/25747#issuecomment-531630599
 
 
   Hi @rdblue , thanks for taking a look! What I want to get consensus on is 
the categories of catalog/table resolution I mentioned in the PR description:
   1. try look up the catalog by name. If no such catalog, and default catalog 
is not set, convert `ParsedStatement` to v1 command like 
`ShowDatabasesCommand`. Otherwise, convert `ParsedStatement` to v2 command like 
`ShowNamespaces`.
   2. try look up the table by name. If no such table, fail. If the table is a 
`V1Table`, convert `ParsedStatement` to v1 command like `CreateTable`. 
Otherwise, convert `ParsedStatement` to v2 command like `CreateV2Table`.
   
   If we agree with this, I don't mind to use different extractors to implement 
this. I'll update this PR to use extractors.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to