jeff303 commented on a change in pull request #25777: [SPARK-29070][CORE] Allow 
SparkLauncher to return full spark-submit c…
URL: https://github.com/apache/spark/pull/25777#discussion_r324685951
 
 

 ##########
 File path: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java
 ##########
 @@ -410,7 +410,7 @@ public SparkAppHandle 
startApplication(SparkAppHandle.Listener... listeners) thr
     return handle;
   }
 
-  private ProcessBuilder createBuilder() throws IOException {
 
 Review comment:
   How about simply logging the command from `SparkLauncher` instead of adding 
a new public method, then?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to