gengliangwang commented on a change in pull request #25804: [SPARK-29096][SQL]
The exact math method should be called only when there is a corresponding
function in Math
URL: https://github.com/apache/spark/pull/25804#discussion_r324736536
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -308,6 +309,7 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
localSparkSession.conf.set(SQLConf.CROSS_JOINS_ENABLED.key, true)
localSparkSession.conf.set(SQLConf.ANSI_SQL_PARSER.key, true)
localSparkSession.conf.set(SQLConf.PREFER_INTEGRAL_DIVISION.key, true)
+ localSparkSession.conf.set(SQLConf.FAIL_ON_INTEGRAL_TYPE_OVERFLOW.key,
true)
Review comment:
I prefer to enable it for all pgSQL tests:
1. If we are going to have one flag for ANSI mode such as
https://github.com/apache/spark/pull/25693, then we should enable all the ANSI
features here.
2. If we have to isolate this flag, then we need to isolate
`SQLConf.ANSI_SQL_PARSER` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
