mgaido91 commented on a change in pull request #25804: [SPARK-29096][SQL] The
exact math method should be called only when there is a corresponding function
in Math
URL: https://github.com/apache/spark/pull/25804#discussion_r324739239
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -308,6 +309,7 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
localSparkSession.conf.set(SQLConf.CROSS_JOINS_ENABLED.key, true)
localSparkSession.conf.set(SQLConf.ANSI_SQL_PARSER.key, true)
localSparkSession.conf.set(SQLConf.PREFER_INTEGRAL_DIVISION.key, true)
+ localSparkSession.conf.set(SQLConf.FAIL_ON_INTEGRAL_TYPE_OVERFLOW.key,
true)
Review comment:
in this way we are running all our tests only in one of the two modes (the
non-default one moreover), so we are not ensuring the behavior on both modes. I
don't think this is a good idea. I think that when we will have the ANSI
feature, we will run these tests both with ANSI enabled and not. Otherwise we
would not provide proper coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
