kiszk commented on a change in pull request #25797: [SPARK-29043][Core] Improve
the concurrent performance of History Server
URL: https://github.com/apache/spark/pull/25797#discussion_r324800234
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -161,6 +160,20 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
new HistoryServerDiskManager(conf, path, listing, clock)
}
+ private val processing = new ConcurrentSkipListSet[String]
Review comment:
How about using `ConcurrentHashMap` instead of `ConcurrentSkipListSet`.
[`ConcurrentSkipListSet`](https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ConcurrentSkipListSet.html)
takes more cost (i.e. `O(log(n))`) compared to `O(1)` in `ConcurrentHashMap`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
