Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3715#discussion_r23660342
--- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
---
@@ -374,49 +375,63 @@ private[spark] object PythonRDD extends Logging {
// The right way to implement this would be to use TypeTags to get the
full
// type of T. Since I don't want to introduce breaking changes
throughout the
// entire Spark API, I have to use this hacky approach:
--- End diff --
I believe that these three comment lines originally referred to the code on
line 381 (now line 395), where we look at the runtime type of the first element
of the iterator. For clarity's sake, I think we should move the new `write`
methods above this comment so that it stays in the right spot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
