srowen edited a comment on issue #16556: [SPARK-19184][MLlib] Improve numerical stability for method tallSkinnyQR. URL: https://github.com/apache/spark/pull/16556#issuecomment-531979613 Hm, I haven't thought about it enough then, but as the # cols increases isn't R less likely to be singular? (EDIT no that doesn't seem to be true, point taken on the scale of the issue) doesn't really matter though. Simple is better than complex, if it fixes it, but if not, yeah something like this may be needed. To be clear, nobody thinks this is the best way to do it. It's just what was implemented so far. To your question of why it hasn't been improved, ¯\_(ツ)_/¯ ? that's OSS. It happens by people doing it. Also I
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
