huaxingao commented on a change in pull request #25776:
[SPARK-28985][PYTHON][ML] Add common classes
(JavaPredictor/JavaClassificationModel/JavaProbabilisticClassifier) in PYTHON
URL: https://github.com/apache/spark/pull/25776#discussion_r324928861
##########
File path: python/pyspark/ml/classification.py
##########
@@ -64,10 +91,56 @@ def numClasses(self):
return self._call_java("numClasses")
+class JavaProbabilisticClassifierParams(HasProbabilityCol, HasThresholds,
JavaClassifierParams):
+ """
+ (Private) Java Probabilistic Classifier Params for classification tasks.
+ """
+ pass
Review comment:
@srowen Thanks for your comments.
I did a quick test using ```print (time.clock() - start_time, "seconds")```
in ```LogisticRegressionTest```to compare the difference between with and
without this no-op class. I didn't see any time degradation with this no-op
class.
Also, I prefer to keep this no-op class so I don't need to make both
```JavaProbabilisticClassifier``` and
```JavaProbabilisticClassificationModel``` to implement ```HasProbabilityCol,
HasThresholds```. I guess we just keep this class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
