Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3715#discussion_r23672024
  
    --- Diff: make-distribution.sh ---
    @@ -188,6 +188,7 @@ echo "Build flags: $@" >> "$DISTDIR/RELEASE"
     # Copy jars
     cp "$SPARK_HOME"/assembly/target/scala*/*assembly*hadoop*.jar 
"$DISTDIR/lib/"
     cp "$SPARK_HOME"/examples/target/scala*/spark-examples*.jar "$DISTDIR/lib/"
    +cp "$SPARK_HOME"/external/kafka/scala*/*kafka*assembly*.jar "$DISTDIR/lib/"
    --- End diff --
    
    We will publish the jar to maven central. It's fine IMO in this patch to 
recommend downloading the published jar. And later on we can just suggest 
linking against the maven coordinates. But I'd like to avoid actually including 
this JAR in the binary distribution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to