HeartSaVioR commented on a change in pull request #25696:
[SPARK-28996][SQL][TESTS] Add tests regarding username of HiveClient
URL: https://github.com/apache/spark/pull/25696#discussion_r324956998
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -222,7 +222,7 @@ private[hive] class HiveClientImpl(
hiveConf
}
- private val userName = UserGroupInformation.getCurrentUser.getShortUserName
+ override val userName = UserGroupInformation.getCurrentUser.getShortUserName
Review comment:
Btw, that would be better to be handled via separate PR if necessary, to
isolate two different things "adding test" and "fixing logic".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
