cloud-fan commented on a change in pull request #20826: [SPARK-2489][SQL]
Support Parquet's optional fixed_len_byte_array
URL: https://github.com/apache/spark/pull/20826#discussion_r324984695
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
##########
@@ -509,6 +509,14 @@ private void readFixedLenByteArrayBatch(
column.putNull(rowId + i);
}
}
+ } else if (column.dataType() == DataTypes.BinaryType) {
Review comment:
We can merge it into the previous if:
```
else if (DecimalType.isByteArrayDecimalType(column.dataType()) ||
column.dataType() == DataTypes.BinaryType)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
