Gschiavon edited a comment on issue #25728: [SPARK-29020][WIP][SQL] Improving 
array_sort behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-532071387
 
 
   The problem here is the naming of the HOF array_sort.
   In the `registry`  we have this :
   ` expression[ArraySort]("array_sort")`
    `expression[ArraySorting]("array_sort")`
   (Note that ArraySorting is a temporary name until we solve this)
   
   I think names should be different, for example, this is array_zip 
(arrays_zip in the code)
   `  expression[ArraysZip]("arrays_zip")`
   `  expression[ZipWith]("zip_with")`
   
   Maybe they don't do exactly the same, I'm not sure.
   
   But other examples with the Array HOF would be: 
   `    expression[ArrayFilter]("filter"),
       expression[ArrayExists]("exists"),
       expression[ArrayForAll]("forall") `
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to