zhengruifeng commented on a change in pull request #25776:
[SPARK-28985][PYTHON][ML] Add common classes
(JavaPredictor/JavaClassificationModel/JavaProbabilisticClassifier) in PYTHON
URL: https://github.com/apache/spark/pull/25776#discussion_r325030263
##########
File path: python/pyspark/ml/classification.py
##########
@@ -1062,9 +1153,8 @@ def featureImportances(self):
@inherit_doc
-class RandomForestClassifier(JavaEstimator, HasFeaturesCol, HasLabelCol,
HasPredictionCol, HasSeed,
- HasRawPredictionCol, HasProbabilityCol,
- RandomForestParams, TreeClassifierParams,
HasCheckpointInterval,
+class RandomForestClassifier(JavaProbabilisticClassifier, HasSeed,
RandomForestParams,
+ TreeClassifierParams, HasCheckpointInterval,
JavaMLWritable, JavaMLReadable):
Review comment:
What about adding some simple tests for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
