HyukjinKwon edited a comment on issue #25799: [SPARK-28483][FOLLOW-UP] Fix flaky test in BarrierTaskContextSuite URL: https://github.com/apache/spark/pull/25799#issuecomment-532180264 @WeichenXu123, while this PR seems fine, please make sure you have a sign-off or an approval from another committer, which is a standard approach. At least, you can wait for some positive comments. Or, please clarify the reason why you're merging it without any sign-off from other people. In this way, you can a) avoid unexpected mistakes, and b) have another person who can take over your change, say, if you happen to leave this project; otherwise, no one can take over if most of changes are just merged without peer-review. Although it is legitimate to merge as a committer as far as I know, practically we should better stick to this practice.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
