Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4239#discussion_r23700874
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala ---
@@ -32,7 +32,12 @@ private[ui] class JobPage(parent: JobsTab) extends
WebUIPage("job") {
def render(request: HttpServletRequest): Seq[Node] = {
listener.synchronized {
- val jobId = request.getParameter("id").toInt
+ val paramaterId = request.getParameter("id")
+ if (paramaterId.equals("")) {
--- End diff --
Yes, but don't you want the code to handle both cases? and test both cases?
On Wed, Jan 28, 2015 at 4:44 PM, Kirill A. Korinskiy <
[email protected]> wrote:
> In core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala
> <https://github.com/apache/spark/pull/4239#discussion_r23700631>:
>
> > @@ -32,7 +32,12 @@ private[ui] class JobPage(parent: JobsTab) extends
WebUIPage("job") {
> >
> > def render(request: HttpServletRequest): Seq[Node] = {
> > listener.synchronized {
> > - val jobId = request.getParameter("id").toInt
> > + val paramaterId = request.getParameter("id")
> > + if (paramaterId.equals("")) {
>
> @srowen <https://github.com/srowen>, yes, you are right.
>
> But for case &id= it's return "". And I used this case for testing.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/4239/files#r23700631>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
