cloud-fan commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#discussion_r325242527
########## File path: docs/sql-keywords.md ########## @@ -280,6 +280,7 @@ Below is a list of all the keywords in Spark SQL. <tr><td>UNKNOWN</td><td>reserved</td><td>non-reserved</td><td>reserved</td></tr> <tr><td>UNLOCK</td><td>non-reserved</td><td>non-reserved</td><td>non-reserved</td></tr> <tr><td>UNSET</td><td>non-reserved</td><td>non-reserved</td><td>non-reserved</td></tr> + <tr><td>UPDATE</td><td>non-reserved</td><td>non-reserved</td><td>reserved</td></tr> Review comment: if UPDATE is reserved in SQL spec, we should make it reserved when ansi parser is enabled. We should put UPDATE in `ansiReserved`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
