gengliangwang commented on a change in pull request #25804: [SPARK-29096][SQL]
The exact math method should be called only when there is a corresponding
function in Math
URL: https://github.com/apache/spark/pull/25804#discussion_r325255782
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -308,6 +310,11 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
localSparkSession.conf.set(SQLConf.CROSS_JOINS_ENABLED.key, true)
localSparkSession.conf.set(SQLConf.ANSI_SQL_PARSER.key, true)
localSparkSession.conf.set(SQLConf.PREFER_INTEGRAL_DIVISION.key, true)
+ localSparkSession.conf.set(SQLConf.FAIL_ON_INTEGRAL_TYPE_OVERFLOW.key,
true)
+ // Propagate the SQL conf FAIL_ON_INTEGRAL_TYPE_OVERFLOW to executor.
+ // TODO: remove this after SPARK-29122 is resolved.
+ localSparkSession.sparkContext.setLocalProperty(
Review comment:
Before https://issues.apache.org/jira/browse/SPARK-29122 is resolved, let's
propagate the conf FAIL_ON_INTEGRAL_TYPE_OVERFLOW to executor.
The issue is test only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
