imback82 commented on a change in pull request #25771: [SPARK-28970][SQL]
Implement USE CATALOG/NAMESPACE for Data Source V2
URL: https://github.com/apache/spark/pull/25771#discussion_r324943885
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/CatalogManager.scala
##########
@@ -77,40 +77,37 @@ class CatalogManager(conf: SQLConf, defaultSessionCatalog:
TableCatalog) extends
private def getDefaultNamespace(c: CatalogPlugin) = c match {
case c: SupportsNamespaces => c.defaultNamespace()
- case _ => Array.empty[String]
+ case _ => Array("default") // The builtin catalog use "default" as the
default database.
Review comment:
Now this will return `Array.empty[String]` if a catalog doesn't support
namespaces.
Also, instead of `CatalogExtension` extending `SupportsNamespace`, I
introduced `BaseSessionCatalog` which inherits both `TableCatalog` and
`SupportsNamespace`, and `CatalogExtension` extends `BaseSessionCatalog`.
This is so that a v2 session catalog can extend `BaseSessionCatalog` instead
of `CatalogExtension`, which requires overriding `setDelegateCatalog`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
