cloud-fan commented on issue #25620: [SPARK-25341][Core] Support rolling back a shuffle map stage and re-generate the shuffle files URL: https://github.com/apache/spark/pull/25620#issuecomment-532312310 @xuanyuanking thanks for the renaming work! After taking a quick look, I think we can go further. It looks to me that we should only use the name `mapIndex` and `mapTaskId` when we really mean it. e.g. `ShuffleStatus.addMapOutput`, `MapStatus.mapTaskId`, etc. When we refer to an identifier of the map, then we should use `mapId`. There are only a few places that we explicitly mean `mapIndex` and/or `mapTaskId`, we can keep the name `mapId` unchange in other places to reduce the diff. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
