srowen commented on a change in pull request #25809: [WIP][SPARK-29113][DOC] 
Fix some annotation errors and remove meaningless annotations in project.
URL: https://github.com/apache/spark/pull/25809#discussion_r325341444
 
 

 ##########
 File path: core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java
 ##########
 @@ -276,8 +276,6 @@ public long pageSizeBytes() {
    *
    * Returns `null` if there was not enough memory to allocate the page. May 
return a page that
    * contains fewer bytes than requested, so callers should verify the size of 
returned pages.
-   *
-   * @throws TooLargePageException
 
 Review comment:
   Another caveat I didn't mention is that it _is_ a little useful to document 
_unchecked_ exceptions this way, as only checked exceptions appear in the 
javadoc. I'd leave this, even without a description.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to