vanzin commented on a change in pull request #25670: [SPARK-28869][CORE] Roll
over event log files
URL: https://github.com/apache/spark/pull/25670#discussion_r325355538
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -435,27 +435,26 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
logDebug(s"Scanning $logDir with lastScanTime==$lastScanTime")
val updated = Option(fs.listStatus(new
Path(logDir))).map(_.toSeq).getOrElse(Nil)
- .filter { entry =>
- !entry.isDirectory() &&
- // FsHistoryProvider used to generate a hidden file which can't be
read. Accidentally
- // reading a garbage file is safe, but we would log an error which
can be scary to
- // the end-user.
- !entry.getPath().getName().startsWith(".") &&
- !isBlacklisted(entry.getPath)
- }
- .filter { entry =>
+ .filter(entry => !isBlacklisted(entry.getPath))
Review comment:
Style is to use `.filter { entry => ... }`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
