huaxingao commented on a change in pull request #25812: 
[SPARK-22796][PYTHON][ML] Add multiple columns support to PySpark 
QuantileDiscretizer
URL: https://github.com/apache/spark/pull/25812#discussion_r325419433
 
 

 ##########
 File path: python/pyspark/ml/feature.py
 ##########
 @@ -2064,6 +2112,20 @@ def getNumBuckets(self):
         """
         return self.getOrDefault(self.numBuckets)
 
+    @since("3.0.0")
+    def setNumBucketsArray(self, value):
+        """
+        Sets the value of :py:attr:`numBucketsArray`.
+        """
+        return self._set(numBucketsArray=value)
+
+    @since("3.0.0")
+    def getNumBucketsArray(self):
+        """
+        Gets the value of numBucketsArray or its default value.
 
 Review comment:
   @viirya Thanks for your comments. 
   I looked setters and getters in other places, for some reason, the doc of 
all the setters have ```:py:attr:```, but the majority of the getters doc don't 
have ```:py:attr:```. I guess I will not add ```:py:attr:``` for this getter 
because all the other getters doc in `QuantileDiscretizer` don't have 
```:py:attr:```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to