vanzin commented on a change in pull request #25670: [SPARK-28869][CORE] Roll
over event log files
URL: https://github.com/apache/spark/pull/25670#discussion_r325424743
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -174,6 +174,17 @@ package object config {
private[spark] val EVENT_LOG_CALLSITE_LONG_FORM =
ConfigBuilder("spark.eventLog.longForm.enabled").booleanConf.createWithDefault(false)
+ private[spark] val EVENT_LOG_ENABLE_ROLLING =
+ ConfigBuilder("spark.eventLog.rollLog")
+ .doc("Whether rolling over event log files is enabled.")
+ .booleanConf.createWithDefault(false)
+
+ private[spark] val EVENT_LOG_ROLLED_EVENT_LOG_MAX_FILE_SIZE =
+ ConfigBuilder("spark.eventLog.rollLog.maxFileSize")
+ .doc("The max size of event log file to be rolled over, in KiB unless
otherwise specified.")
Review comment:
You don't need to change existing ones, just don't mention units in docs
when adding new configs. Users are expected to provide the unit in the config
value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
