Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/4057#issuecomment-71904455
A few things I feel we should add in this PR.
* Parsing `Coalesce` in HiveQL.
* Unit tests to make sure we can correctly determine the return type (if we
do not have these tests)
* Unit tests to make sure we can throw the correct exception when we get
cases that we do not handle (for example, complex types).
I think we also need to add a rule in `DecimalPrecision` for `Coalesce`.
But, I think it is fine to do it in a follow-up PR (Can you create a PR for
it?).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
