HyukjinKwon commented on a change in pull request #25820: [SPARK-29101][SQL]
Fix count API for csv file when DROPMALFORMED mode is selected
URL: https://github.com/apache/spark/pull/25820#discussion_r325548784
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
##########
@@ -2109,4 +2110,17 @@ class CSVSuite extends QueryTest with
SharedSparkSession with TestCsvData {
"expect the TextParsingException truncate the error content to be 1000
length.")
}
}
+
+ test("SPARK-29101 test count with DROPMALFORMED mode") {
+ Seq((true, 4), (false, 3)).foreach { record =>
Review comment:
Sorry, one more nit:
```scala
Seq((true, 4), (false, 3)).foreach { case (csvColumnPruning, count) =>
withSQLConf(SQLConf.CSV_PARSER_COLUMN_PRUNING.key ->
csvColumnPruning.toString) {
...
assert(record._2 == count)
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
