srowen commented on a change in pull request #25818: [SPARK-29121][ML][MLLIB]
Support for dot product operation on Vector(s)
URL: https://github.com/apache/spark/pull/25818#discussion_r325734638
##########
File path: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala
##########
@@ -239,6 +247,14 @@ object Vectors {
}.toSeq)
}
+ /**
+ * Calculate the dot product of two vectors.
+ *
+ * If `size` does not match an [[IllegalArgumentException]] is thrown.
+ */
+ @Since("3.0.0")
+ def dot(v1: Vector, v2: Vector): Double = BLAS.dot(v1, v2)
Review comment:
Actually, do we need this method? BLAS.dot() already exists. I can see an
instance method taking a single arg for parity with Pyspark, but this doesn't
add much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
