cloud-fan commented on a change in pull request #25620: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/25620#discussion_r325775928
##########
File path:
core/src/main/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriter.java
##########
@@ -109,7 +109,6 @@ public UnsafeShuffleWriter(
BlockManager blockManager,
TaskMemoryManager memoryManager,
SerializedShuffleHandle<K, V> handle,
- int mapId,
Review comment:
previously, we can get the `mapId` via `taskContext.partitionId`, but we
still pass in the `mapId`. It's more clear to decide the `mapId` in a
high-level place instead of the underlying writer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
