HeartSaVioR commented on a change in pull request #25830: [SPARK-29140][SQL]
Handle BinaryType of parameter properly in HashAggregateExec
URL: https://github.com/apache/spark/pull/25830#discussion_r325882156
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##########
@@ -392,6 +394,14 @@ case class HashAggregateExec(
""".stripMargin
}
+ private def typeNameForCodegen(clazz: Class[_]): String = {
Review comment:
Nice suggestions of both comments! Will address.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
