cloud-fan commented on a change in pull request #25771: [SPARK-28970][SQL]
Implement USE CATALOG/NAMESPACE for Data Source V2
URL: https://github.com/apache/spark/pull/25771#discussion_r325965604
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/DelegatingCatalogExtension.java
##########
@@ -76,25 +77,78 @@ public Table createTable(
StructType schema,
Transform[] partitions,
Map<String, String> properties) throws TableAlreadyExistsException,
NoSuchNamespaceException {
- return delegate.createTable(ident, schema, partitions, properties);
+ return asTableCatalog().createTable(ident, schema, partitions, properties);
}
@Override
public Table alterTable(
Identifier ident,
TableChange... changes) throws NoSuchTableException {
- return delegate.alterTable(ident, changes);
+ return asTableCatalog().alterTable(ident, changes);
}
@Override
public boolean dropTable(Identifier ident) {
- return delegate.dropTable(ident);
+ return asTableCatalog().dropTable(ident);
}
@Override
public void renameTable(
Identifier oldIdent,
Identifier newIdent) throws NoSuchTableException,
TableAlreadyExistsException {
- delegate.renameTable(oldIdent, newIdent);
+ asTableCatalog().renameTable(oldIdent, newIdent);
+ }
+
+ @Override
+ public String[] defaultNamespace() {
+ return asNamespaceCatalog().defaultNamespace();
+ }
+
+ @Override
+ public String[][] listNamespaces() throws NoSuchNamespaceException {
+ return asNamespaceCatalog().listNamespaces();
+ }
+
+ @Override
+ public String[][] listNamespaces(String[] namespace) throws
NoSuchNamespaceException {
+ return asNamespaceCatalog().listNamespaces(namespace);
+ }
+
+ @Override
+ public boolean namespaceExists(String[] namespace) {
+ return asNamespaceCatalog().namespaceExists(namespace);
+ }
+
+ @Override
+ public Map<String, String> loadNamespaceMetadata(
+ String[] namespace) throws NoSuchNamespaceException {
+ return asNamespaceCatalog().loadNamespaceMetadata(namespace);
+ }
+
+ @Override
+ public void createNamespace(
+ String[] namespace,
+ Map<String, String> metadata) throws NamespaceAlreadyExistsException {
+ asNamespaceCatalog().createNamespace(namespace, metadata);
+ }
+
+ @Override
+ public void alterNamespace(
+ String[] namespace,
+ NamespaceChange... changes) throws NoSuchNamespaceException {
+ asNamespaceCatalog().alterNamespace(namespace, changes);
+ }
+
+ @Override
+ public boolean dropNamespace(String[] namespace) throws
NoSuchNamespaceException {
+ return ((SupportsNamespaces)delegate).dropNamespace(namespace);
Review comment:
nit: this one is left behind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
