advancedxy commented on issue #25814: [SPARK-19926][PYSPARK] make captured 
exception from JVM side user friendly
URL: https://github.com/apache/spark/pull/25814#issuecomment-533189370
 
 
   > Have you tried this with python3?
   
   Yes, I ran tests with python3.7 on my local machine, but not 
`dev/lint-python`.
   
   Looks like flake cannot infer that unicode is never used for python3.  The 
code is correct in the runtime. 
   
   Seems we don't run lint-python on the Jenkins? @HyukjinKwon can you help 
confirming that? 
   
   I'd like to address this problem in 
https://github.com/apache/spark/pull/25847, the fix is simple, just
   add the following in the begin:
   ```
   import py4j
   import sys
   
   if sys.version_info.major >= 3:
       unicode = str
   ```
   
   Does that sound reasonable to you @HyukjinKwon ? Or I should submit a follow 
up pr for this problem? Also cc @viirya 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to