gatorsmile commented on a change in pull request #25849: [SPARK-29175][SQL]
Make maven central repository in IsolatedClientLoader configurable
URL: https://github.com/apache/spark/pull/25849#discussion_r326252552
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1979,6 +1979,13 @@ object SQLConf {
.doc("When true, the ArrayExists will follow the three-valued boolean
logic.")
.booleanConf
.createWithDefault(true)
+
+ private[spark] val CENTRAL_REPOSITORY =
+ ConfigBuilder("spark.sql.centralRepository")
+ .doc("The default central repository used for downloading Hive jars " +
+ "in IsolatedClientLoader.")
+ .stringConf
+ .createWithDefault("https://repo1.maven.org/maven2";)
Review comment:
We do not need to provide a default value here. Without any value, it will
use maven central, I think.
In the Hive tests, we can set the conf to some default repo in
TestHiveContext? See this link
https://www.deps.co/guides/public-maven-repositories/ We can use google mirror
for avoiding we are blocked by maven central.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
