rdblue commented on a change in pull request #25838: [SPARK-29158][SQL] Expose
SerializableConfiguration for DataSource V2 developers
URL: https://github.com/apache/spark/pull/25838#discussion_r326294738
##########
File path:
core/src/main/scala/org/apache/spark/util/SerializableConfiguration.scala
##########
@@ -20,7 +20,13 @@ import java.io.{ObjectInputStream, ObjectOutputStream}
import org.apache.hadoop.conf.Configuration
-private[spark]
+import org.apache.spark.annotation.DeveloperApi
+
+/**
+ * Helper wrapper to serialize a Hadoop configuration. Intended for use when
implementing
+ * DataSourceV2 readers & writers which depend on the Hadoop configuration
from the driver node.
+ */
+@DeveloperApi
Review comment:
This file [hasn't changed in 4
years](https://github.com/apache/spark/commits/master/core/src/main/scala/org/apache/spark/util/SerializableConfiguration.scala),
so I don't think there is much risk in using `@DeveloperApi`. I think having a
Java test is a good idea though (if it doesn't work, we can replace it with a
Java implementation).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
