srowen commented on a change in pull request #25849: [SPARK-29175][SQL] Make
maven central repository in IsolatedClientLoader configurable
URL: https://github.com/apache/spark/pull/25849#discussion_r326373407
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1979,6 +1979,13 @@ object SQLConf {
.doc("When true, the ArrayExists will follow the three-valued boolean
logic.")
.booleanConf
.createWithDefault(true)
+
+ private[spark] val CENTRAL_REPOSITORY =
+ ConfigBuilder("spark.sql.centralRepository")
+ .doc("The default central repository used for downloading Hive jars " +
+ "in IsolatedClientLoader.")
+ .stringConf
+ .createWithDefault("https://repo1.maven.org/maven2";)
Review comment:
Yes you are right; see `SparkSubmitUtils.buildIvySettings`. It's an
additional "remote repo", which is used in addition to central. That's why I'm
saying this should not be called "central repo", as it won't (and shouldn't)
override resolving against Maven Central -- almost nothing would work without
that. This looks good if we can clarify the semantics in the naming and
description. The default should be "None" here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
