dongjoon-hyun commented on issue #25851: [SPARK-29172][SQL] Improve shown 
message on sql show()
URL: https://github.com/apache/spark/pull/25851#issuecomment-533315949
 
 
   @TomokoKomiyama . Thank you for making a PR, but this causes a severe 
regression as @srowen and @kiszk suggested in the above. I can show you by 
example.
   
   **BEFORE**
   ```scala
   scala> spark.version
   res1: String = 2.4.4
   
   scala> spark.time(spark.range(1000000000000L).show(1))
   +---+
   | id|
   +---+
   |  0|
   +---+
   only showing top 1 row
   
   Time taken: 47 ms
   ```
   
   **This PR**
   ```scala
   scala> spark.version
   res5: String = 3.0.0-SNAPSHOT
   
   scala> spark.time(spark.range(1000000000000L).show(1))
   +---+
   | id|
   +---+
   |  0|
   +---+
   only showing top 1 / 1000000000000 row
   
   Time taken: 4820 ms
   ```
   
   I'll close this PR due to the above reason. I hope we can meet in another 
your PR. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to