maropu commented on a change in pull request #25666: [SPARK-28962][SQL] Provide
index argument to filter lambda functions
URL: https://github.com/apache/spark/pull/25666#discussion_r326427367
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
##########
@@ -357,10 +359,23 @@ case class ArrayFilter(
override def bind(f: (Expression, Seq[(DataType, Boolean)]) =>
LambdaFunction): ArrayFilter = {
val ArrayType(elementType, containsNull) = argument.dataType
- copy(function = f(function, (elementType, containsNull) :: Nil))
+ function match {
+ case LambdaFunction(_, arguments, _) if arguments.size == 2 =>
+ copy(function = f(function, (elementType, containsNull) ::
(IntegerType, false) :: Nil))
+ case _ =>
+ copy(function = f(function, (elementType, containsNull) :: Nil))
+ }
}
- @transient lazy val LambdaFunction(_, Seq(elementVar: NamedLambdaVariable),
_) = function
+ @transient lazy val (elementVar, indexVar) = {
+ val LambdaFunction(_, (elementVar: NamedLambdaVariable) +: tail, _) =
function
+ val indexVar = if (tail.nonEmpty) {
Review comment:
nit: `val indexVar =
tail.headOption.map(_.asInstanceOf[NamedLambdaVariable])`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
