viirya commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-533414231 As I said, I think it is possible an aggregate function accesses complex data input like array but uses a buffer attribute which is supported by HashAggregateExec. If you just filter out complex data types out, the split function for such aggregation function won't work. So currently this looks good to me. I am not sure if we want to turn off split mode just because of array argument as @maropu suggested. cc @cloud-fan
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
