cloud-fan commented on a change in pull request #25767: [SPARK-29062][SQL] Add
V1_BATCH_WRITE to the TableCapabilityChecks
URL: https://github.com/apache/spark/pull/25767#discussion_r326498867
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -267,6 +262,10 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) {
import
org.apache.spark.sql.execution.datasources.v2.DataSourceV2Implicits._
provider.getTable(dsOptions) match {
case table: SupportsWrite if table.supports(BATCH_WRITE) =>
+ if (partitioningColumns.nonEmpty) {
Review comment:
BTW, technically we only need to assert no partition columns for append and
overwrite. Since the v2 write here only supports append and overwrite, we can
revisit it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
