holdenk commented on issue #24839: [SPARK-27258][K8S]Deal with the k8s resource names that don't match their own regular expression URL: https://github.com/apache/spark/pull/24839#issuecomment-533624838 Hi @hehuiyuan I don't completely understand your response. Let me write my understanding and you can point out where we're not matching up: So the resourceNamePrefix is (with the change) gauranteed to start with something in `[a-z0-9]`. The point of the `Character.isLetter` is to filter out anything that starts with a number for service because only service has that requirement. While `Character.isLetter` accepts more than just `[a-z]` the other things it accepts has already been filtered out so in practice this is the same as doing a regex check for `^[a-z].*` If that's the case maybe just add a comment about that, because it takes a bit of tracing through the code to build up that context.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
