holdenk commented on a change in pull request #25614: [SPARK-28887][K8S]
Executor pod status fix
URL: https://github.com/apache/spark/pull/25614#discussion_r326711915
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshot.scala
##########
@@ -59,7 +61,24 @@ object ExecutorPodsSnapshot extends Logging {
case "pending" =>
PodPending(pod)
case "running" =>
- PodRunning(pod)
+ // TODO(SPARK-29023): Kubernenetes 1.17 sidecar container feature
will
+ // make this code redundant
https://github.com/kubernetes/enhancements/issues/753
+ // Checking executor container status is not terminated
+ // Pod status can still be running if sidecar container status is
running
Review comment:
That's a good point. I don't know how often the sidecar is "critical" to
keep running along side Spark so I'll defer to other's judgement here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
