holdenk commented on a change in pull request #25514: [SPARK-28784][SS] Use
CheckpointFileManager in StreamExecution/StreamingQueryManager for checkpoint
dirs
URL: https://github.com/apache/spark/pull/25514#discussion_r326716226
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
##########
@@ -133,9 +134,8 @@ abstract class StreamExecution(
.stripMargin)
}
}
- val checkpointDir = checkpointPath.makeQualified(fs.getUri,
fs.getWorkingDirectory)
Review comment:
I think so. We're using the `checkpointFileManager` for this behavior now in
the PR so we are not directly making FS operations. Looking inside of the
default FileSystem impl we don't explicitly translate this to a fully-qualified
path, do you think that would be an issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
