jinxingwang commented on a change in pull request #25614: [SPARK-28887][K8S]
Executor pod status fix
URL: https://github.com/apache/spark/pull/25614#discussion_r326720146
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshot.scala
##########
@@ -59,7 +61,24 @@ object ExecutorPodsSnapshot extends Logging {
case "pending" =>
PodPending(pod)
case "running" =>
- PodRunning(pod)
+ // TODO(SPARK-29023): Kubernenetes 1.17 sidecar container feature
will
+ // make this code redundant
https://github.com/kubernetes/enhancements/issues/753
+ // Checking executor container status is not terminated
+ // Pod status can still be running if sidecar container status is
running
Review comment:
The current state is if any container is running, the pod will keep running,
so there is no case "Spark executor is running but pod is not healthy" but will
happen "pod is healthy but Spark executor container(or any sidecar container)
is not running "
My change made "main(executor)" container reflect on the pod status.
Your point is very good, that other sidecar also should be healthy when they
should be. My thoughts on it are, sidecars are not as critical as "main"
container in some case, and should not necessary cause pod to restart all the
time. so I will like it to happen is to let "main(executor)" container
determine if a pod should be restarted. which should be main container error
out when any of its sidecar container is not healthy.
Let me know what you guys think. thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
